use secret for SMTP credentials #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, looks good, will you rebase the changes? |
sebtiz13
force-pushed
the
feat/support-secret-smtp
branch
from
a5936da to
407bc0d
Compare
sebtiz13
force-pushed
the
feat/support-secret-smtp
branch
from
651a7e5 to
c7de07a
Compare
needed to support `SMTP_SECURITY`
sebtiz13
force-pushed
the
feat/support-secret-smtp
branch
from
c7de07a to
e9c91bc
Compare
|
It's ok, I have rebase the branch to merge with previous changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, just a little improvement to use a secret instead of configmap to store SMTP credentials because It's more securely.
I have also updated to use the new env variable
SMTP_SECURITYinstead ofSMTP_SSLandSMTP_EXPLICIT_TLS