loader of MAD-X errors #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequence instead of an error table file
- apply_madx_errors is now an option of line.from_madx_sequence - all apply_xyz_error_to functions are now private to discourage manual usage due to problems if correct order is not adhered to
attributes instead of predefined list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the loader of MAD-X errors so it uses a new feature of cpymad that allows us to access element errors directly instead of saving them to a file in cpymad and then loading the file in pysixtrack.
Furthermore the function line.apply_madx_errors was made private and is now an option of line.from_madx_sequence. This way we fix #42 without taking the possibility to still manually load errors. Similarly the apply_xyz_error_to function were made private to "fix" #53 without needing any housekeeping of the misalignments.