Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reduced model method from robot-handler #32

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

edantec
Copy link
Collaborator

@edantec edantec commented Dec 20, 2024

The model provided to robot-handler constructor should not be reduced by the robot-handler, this is something the user ought to do by himself.

This PR also corrects the python example for kinodynamics by copying the derivative state at runtime (derivative state is now const and unmodifiable).

@EtienneAr EtienneAr self-requested a review December 21, 2024 10:20
src/robot-handler.cpp Outdated Show resolved Hide resolved
src/robot-handler.cpp Outdated Show resolved Hide resolved
examples/utils.py Outdated Show resolved Hide resolved
@edantec edantec requested a review from ManifoldFR January 6, 2025 14:54
Copy link
Member

@ManifoldFR ManifoldFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@edantec edantec merged commit b7c7041 into main Jan 6, 2025
11 checks passed
@edantec edantec deleted the topic/remove_reduced_model branch January 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants