Fix leak when ULP sleep ack is sent #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An SKB buffer is allocated here to contain the acknowledge to ULP sleep request but it is never freed. This issue has been discovered with kmemleak reporting: unreferenced object 0xbd931b40 (size 192): comm "SDIO-RX-Thread", pid 115, jiffies 4294939787 (age 385.370s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<80128470>] kmem_cache_alloc+0x1c8/0x254 [<8072c2d8>] __build_skb+0x34/0x9c [<8072c360>] build_skb+0x20/0x78 [<8072c43c>] __alloc_rx_skb+0x84/0xf4 [<8072c4d8>] __netdev_alloc_skb+0x2c/0x54 [<7f04e290>] rsi_send_ack_for_ulp_entry+0x28/0xa0 [rsi_91x] [<7f052ad4>] rsi_mgmt_pkt_recv+0x4c0/0x10d0 [rsi_91x] [<7f049ed4>] rsi_read_pkt+0x104/0x268 [rsi_91x] [<7f070168>] rsi_sdio_rx_thread+0xa8/0x180 [rsi_sdio] [<8005065c>] kthread+0xec/0x104 [<800107e8>] ret_from_fork+0x14/0x2c [<ffffffff>] 0xffffffff In order to reproduce it just load the module and wait, you will see the memory usage increasing rapidly. Signed-off-by: Stefano Manni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An SKB buffer is allocated here to contain the
acknowledge to ULP sleep request but it is never freed.
This issue has been discovered with kmemleak reporting:
unreferenced object 0xbd931b40 (size 192):
comm "SDIO-RX-Thread", pid 115, jiffies 4294939787 (age 385.370s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<80128470>] kmem_cache_alloc+0x1c8/0x254
[<8072c2d8>] __build_skb+0x34/0x9c
[<8072c360>] build_skb+0x20/0x78
[<8072c43c>] __alloc_rx_skb+0x84/0xf4
[<8072c4d8>] __netdev_alloc_skb+0x2c/0x54
[<7f04e290>] rsi_send_ack_for_ulp_entry+0x28/0xa0 [rsi_91x]
[<7f052ad4>] rsi_mgmt_pkt_recv+0x4c0/0x10d0 [rsi_91x]
[<7f049ed4>] rsi_read_pkt+0x104/0x268 [rsi_91x]
[<7f070168>] rsi_sdio_rx_thread+0xa8/0x180 [rsi_sdio]
[<8005065c>] kthread+0xec/0x104
[<800107e8>] ret_from_fork+0x14/0x2c
[] 0xffffffff
In order to reproduce it just load the module and wait,
you will see the memory usage increasing rapidly.
Signed-off-by: Stefano Manni [email protected]