USDC Noble support for Pool Stats, Pool and Balances #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pgoos
commented
Dec 8, 2023
pgoos
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #850 +/- ##
==========================================
- Coverage 28.15% 28.06% -0.10%
==========================================
Files 127 129 +2
Lines 2291 2302 +11
Branches 524 528 +4
==========================================
+ Hits 645 646 +1
- Misses 1643 1653 +10
Partials 3 3
|
snobbee
reviewed
Dec 8, 2023
app/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "app", | |||
| "version": "2.14.20", | |||
| "version": "2.14.22", | |||
There was a problem hiding this comment.
@pgoos any reason why we are skipping 2.14.21 ?
There was a problem hiding this comment.
it's because when I created a commit for 2.14.21, it contained some changes that shouldn't be there so I created another commit to withdraw those changes and bumped version again.
app/src/hooks/usePoolStats.ts
Outdated
| // arb: null, | ||
| // } | ||
| // ); | ||
| // }); |
There was a problem hiding this comment.
@pgoos can you add a comment above to state why this code needs to be commented or kept commented here thanks
snobbee
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.