Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: get_die now outputs the unmodified die position from the prober api #218

Merged
merged 2 commits into from
Apr 29, 2024
Merged

ENH: get_die now outputs the unmodified die position from the prober api #218

merged 2 commits into from
Apr 29, 2024

Conversation

mjmucha
Copy link
Member

@mjmucha mjmucha commented Apr 29, 2024

Removed custom die position mappings.

get_die() now outputs the direct response from the prober api.

@mjmucha mjmucha requested a review from cbespin April 29, 2024 11:53
cbespin
cbespin approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@cbespin cbespin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cbespin cbespin merged commit ce1c257 into master Apr 29, 2024
5 checks passed
@cbespin
Copy link
Contributor

cbespin commented Apr 29, 2024

Thanks, looks nice! Merged

@cbespin cbespin deleted the correct_prober_api_response branch April 29, 2024 16:16
@cbespin cbespin mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbespin cbespin cbespin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjmucha @cbespin