Be resilient to environment

Shopify · Jan 10, 2025 · 2571a08 · 2571a08
1 parent 40830d9
commit 2571a08
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/tapioca/dsl/compilers/delegate.rb b/lib/tapioca/dsl/compilers/delegate.rb
@@ -56,6 +56,8 @@ class << self
 
           sig { override.returns(T::Enumerable[::Module]) }
           def gather_constants
+            return [] unless defined?(Tapioca::Dsl::Compilers::Extensions::Module)
+
             all_classes.select do |c|
               c.singleton_class < Tapioca::Dsl::Compilers::Extensions::Module &&
                 T.unsafe(c).__tapioca_delegated_methods.any?
@@ -87,6 +89,8 @@ def decorate
                   signature_of(constant.instance_method(delegated_method[:to]))
                 end
 
+                next unless sig
+
                 delegate_klass = if delegated_method[:allow_nil]
                   sig.return_type.unwrap_nilable.raw_type
                 else

diff --git a/lib/tapioca/dsl/extensions/delegate.rb b/lib/tapioca/dsl/extensions/delegate.rb
@@ -7,8 +7,6 @@
   return
 end
 
-return unless Module.respond_to?(:delegate)
-
 module Tapioca
   module Dsl
     module Compilers

diff --git a/spec/tapioca/cli/dsl_spec.rb b/spec/tapioca/cli/dsl_spec.rb
@@ -2847,6 +2847,7 @@ class PostCompiler < Tapioca::Dsl::Compiler
               Tapioca::Dsl::Compilers::ActiveRecordStore                   enabled
               Tapioca::Dsl::Compilers::ActiveSupportConcern                enabled
               Tapioca::Dsl::Compilers::ActiveSupportCurrentAttributes      enabled
+              Tapioca::Dsl::Compilers::Delegate                            enabled
               Tapioca::Dsl::Compilers::MixedInClassAttributes              enabled
               Tapioca::Dsl::Compilers::SidekiqWorker                       enabled
               Tapioca::Dsl::Compilers::SmartProperties                     enabled
@@ -2882,6 +2883,7 @@ class PostCompiler < Tapioca::Dsl::Compiler
               Tapioca::Dsl::Compilers::ActiveRecordStore                   enabled
               Tapioca::Dsl::Compilers::ActiveSupportConcern                enabled
               Tapioca::Dsl::Compilers::ActiveSupportCurrentAttributes      enabled
+              Tapioca::Dsl::Compilers::Delegate                            enabled
               Tapioca::Dsl::Compilers::MixedInClassAttributes              enabled
               Tapioca::Dsl::Compilers::SidekiqWorker                       enabled
               Tapioca::Dsl::Compilers::SmartProperties                     disabled
@@ -2917,6 +2919,7 @@ class PostCompiler < Tapioca::Dsl::Compiler
               Tapioca::Dsl::Compilers::ActiveRecordStore                   disabled
               Tapioca::Dsl::Compilers::ActiveSupportConcern                disabled
               Tapioca::Dsl::Compilers::ActiveSupportCurrentAttributes      disabled
+              Tapioca::Dsl::Compilers::Delegate                            disabled
               Tapioca::Dsl::Compilers::MixedInClassAttributes              disabled
               Tapioca::Dsl::Compilers::SidekiqWorker                       disabled
               Tapioca::Dsl::Compilers::SmartProperties                     enabled