Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HG][SG] Category name fixes #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ricardotejedorsanz
Copy link
Contributor

Creating this issue as a placeholder to fix two typos in category names:

  • gid://shopify/TaxonomyCategory/sg-1-7-10-2 Sporting Goods > Athletics > Coaching & Officiating > Sport & Safety Whistles > Ginger Grip Whistles should be Finger Grip Whistles
  • gid://shopify/TaxonomyCategory/hg-11-6-2-7-32 Home & Garden > Kitchen & Dining > Kitchen Appliance Accessories > Coffee Maker & Espresso Machine Accessories > Coffee Maker & Espresso Machine Replacement Parts > Rubber Foots should be Rubber Feet

Ideally, we shouldn't have to archive and create new categories, since there's no change in what they represent. We need to consider how this might impact bulk imports/exports as both the name and gid are supported, but aim to reduce toil to fix typos or style issues. cc @danielpgross

@ricardotejedorsanz
Copy link
Contributor Author

I also ran all of our nodes through ChatGPT to see if it would catch any other errors... haven't had a chance to review but here is all the outputs.

cc @ornanatan --we can review this together 🙏

Copy link
Collaborator

@danielpgross danielpgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @tylerrowsell that the name changes (instead of archive+create) should be safe given the small impact.

I also looked through the diff to confirm it's as expected. It took me a bit to understand why the dist localization files were changed, considering that data localization files didn't change. Then I realized it's because the en ordering was changed, and that's what's used to generate the localization files too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-04 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants