-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG 2025-01.md #536
base: main
Are you sure you want to change the base?
Conversation
2nd commit with our logic for Shopify mappings supporting cascading versions (cc @chesterbot01): |
CHANGELOG.md
Outdated
@@ -1,6 +1,12 @@ | |||
## 2025-01 (unstable) | |||
## 2025-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this with (unstable)
so we can merge the rest of the changes? And when we're cutting the release itself is when we can drop unstable (since we'll have to re-add it back after anyways)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other reason to drop the removal of (unstable)
is we really only want that to be part of cutting a release vs something that happens standalone
1717ab6
to
97face1
Compare
The link does not work. |
@chesterbot01 Here's an updated link --a wording change as per the screenshot, based on the changes implemented in this PR: #526 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Should be fine to merge now if we're not removing (unstable)
in this PR
To merge when we’re ready to roll out
2025-01
:@danielpgross Not urgent, but we should probably update our README with the new commands as we start killing code 🙏