Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG 2025-01.md #536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardotejedorsanz
Copy link
Contributor

To merge when we’re ready to roll out 2025-01:

  • Removes "unstable."
  • Adds localization and development tool sections.
  • Fixes a typo.

@danielpgross Not urgent, but we should probably update our README with the new commands as we start killing code 🙏

@ricardotejedorsanz
Copy link
Contributor Author

2nd commit with our logic for Shopify mappings supporting cascading versions (cc @chesterbot01):
image

CHANGELOG.md Outdated
@@ -1,6 +1,12 @@
## 2025-01 (unstable)
## 2025-01
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this with (unstable) so we can merge the rest of the changes? And when we're cutting the release itself is when we can drop unstable (since we'll have to re-add it back after anyways)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely!

Copy link
Collaborator

@elsom25 elsom25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other reason to drop the removal of (unstable) is we really only want that to be part of cutting a release vs something that happens standalone

@chesterbot01
Copy link
Contributor

2nd commit with our logic for Shopify mappings supporting cascading versions (cc @chesterbot01):

The link does not work.

@ricardotejedorsanz
Copy link
Contributor Author

ricardotejedorsanz commented Jan 24, 2025

The link does not work.

@chesterbot01 Here's an updated link --a wording change as per the screenshot, based on the changes implemented in this PR: #526

Copy link
Collaborator

@danielpgross danielpgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Should be fine to merge now if we're not removing (unstable) in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants