Fix dist sort order for localized Values
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpgross
requested review from
elsom25,
ricardotejedorsanz and
tylerrowsell
elsom25
reviewed
Jan 16, 2025
elsom25
approved these changes
Jan 16, 2025
Merge activity
|
danielpgross
deleted the
01-16-fix_dist_sort_order_for_localized_value_s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #528, we discovered that new localized
distoutput forValues had a different sort order than existing files.The reason turned out to be that the old implementation sorted localized values according to their English names, while the new one sorted according to the localized names.
This PR changes the sort logic to match the previous behaviour: sorting by the English name, regardless of the localization. It also adds tests to cover this case.
I tested generating
distfiles for values with thefrlocale and the changes were as expected.