Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Github workflow to generate missing mappings #527

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove Github workflow to generate missing mappings #527

merged 1 commit into from
Jan 14, 2025

Conversation

danielpgross
Copy link
Collaborator

@danielpgross danielpgross commented Jan 14, 2025 •
edited
Loading

Cleaning up this workflow, which is no longer used.

@danielpgross Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@danielpgross danielpgross marked this pull request as ready for review January 14, 2025 18:35
elsom25
elsom25 reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@elsom25 elsom25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we see this coming back? Are we comfortable with local runs only? Or do we see ourselves nuking the tooling altogether?

@danielpgross Graphite App
Copy link
Collaborator Author

@ricardotejedorsanz @ornanatan do you think we'll still want the local tooling for generating missing mappings?

@danielpgross Graphite App
Copy link
Collaborator Author

danielpgross commented Jan 14, 2025 •
edited
Loading

Merge activity

  • Jan 14, 4:09 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 14, 4:12 PM EST: A user merged this pull request with Graphite.

@danielpgross danielpgross merged commit fc99e6b into main Jan 14, 2025
6 checks passed
@danielpgross danielpgross deleted the 01-14-remove_github_workflow_to_generate_missing_mappings branch January 14, 2025 21:12
@ricardotejedorsanz
Copy link
Contributor

@danielpgross I think we'll still need some sort of tooling, especially when/if we support more 3P mappings in the public repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerrowsell tylerrowsell tylerrowsell approved these changes

@elsom25 elsom25 elsom25 approved these changes

@jessevogt jessevogt Awaiting requested review from jessevogt

@ricardotejedorsanz ricardotejedorsanz Awaiting requested review from ricardotejedorsanz

Assignees
No one assigned
Labels
Hackerone security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielpgross @ricardotejedorsanz @elsom25 @tylerrowsell