New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefetch to sort, pagination resets and fix params mutation #88

Open

gitchinoe wants to merge 1 commit into Shopify:main from gitchinoe:sortfilter-patch

gitchinoe commented Jan 13, 2025 •

edited

Loading

This commit fixes:

possible blank pages when paginating to the end and applying filters afterwards (e.g. last page + "out of stock" filter), by resetting pagination.
mutating the search params in the getSortLink function, briefly breaking SortMenu label (or expected .get() value) until after navigation when useSearchParams is back on track.

Also adds prefetch behavior to SortMenu items.


          add prefetch to sort, pagination resets and fix params mutation

74f87a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet