add deferred & critical data pattern #62
michenlyci.yml
on: pull_request
⬣ ESLint
28s
⬣ Prettier
28s
⬣ Typescript
49s
⬣ Playwright tests
3m 3s
Annotations
11 errors and 6 warnings
|
⬣ Typescript:
app/routes/($locale)._index.tsx#L161
Property 'products' does not exist on type 'JsonifyObject<HomepageFeaturedProductsQuery & StorefrontError> | null'.
|
|
⬣ Typescript:
app/routes/($locale)._index.tsx#L178
Property 'hero' does not exist on type 'JsonifyObject<HeroCollectionContentQuery & StorefrontError> | null'.
|
|
⬣ Typescript:
app/routes/($locale)._index.tsx#L189
Property 'collections' does not exist on type 'JsonifyObject<HomepageFeaturedCollectionsQuery & StorefrontError> | null'.
|
|
⬣ Typescript:
app/routes/($locale)._index.tsx#L205
Property 'hero' does not exist on type 'JsonifyObject<HeroCollectionContentQuery & StorefrontError> | null'.
|
|
⬣ Typescript:
app/routes/($locale).products.$productHandle.tsx#L42
Cannot find name 'params'.
|
|
⬣ Typescript:
app/routes/($locale).products.$productHandle.tsx#L68
Type 'string | undefined' is not assignable to type 'string'.
|
|
⬣ Typescript:
app/routes/($locale).products.$productHandle.tsx#L118
Cannot find name 'context'.
|
|
⬣ Typescript:
app/routes/($locale).products.$productHandle.tsx#L121
Cannot find name 'context'.
|
|
⬣ Typescript:
app/routes/($locale).products.$productHandle.tsx#L122
Cannot find name 'context'.
|
|
⬣ Typescript:
app/routes/($locale).search.tsx#L98
Cannot find name 'shouldGetRecommendations'.
|
|
⬣ Playwright tests
Process completed with exit code 1.
|
|
⬣ ESLint:
app/routes/($locale)._index.tsx#L83
Unexpected console statement
|
|
⬣ ESLint:
app/routes/($locale)._index.tsx#L97
Unexpected console statement
|
|
⬣ ESLint:
app/routes/($locale)._index.tsx#L110
Unexpected console statement
|
|
⬣ ESLint:
app/routes/($locale)._index.tsx#L124
Unexpected console statement
|
|
⬣ Playwright tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "playwright-report".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
playwright-report
Expired
|
3.24 MB |
|