Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support I/O Timeouts on Unix Sockets #34

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

nickamorim
Copy link

Description

socket_timeout is currently only configured for TCP sockets. This PR makes it such that Unix sockets also adhere to timeouts.

@nickamorim nickamorim requested a review from grcooper January 20, 2025 20:31
@nickamorim nickamorim self-assigned this Jan 20, 2025
@grcooper
Copy link

We wrote a simple client/server in ruby to confirm that this wasn't working before, but is now working with the changes for UDS.

@nickamorim nickamorim merged commit 430673f into main Jan 20, 2025
10 checks passed
@nickamorim nickamorim deleted the nickamorim/unix-timeout branch January 20, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants