Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 remove redundant/unused arguments #33

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

nickamorim
Copy link

Description

This PR removes the key_manager from PipelinedSetter since it is unused. Also, we don't need to explicitly rescue Dalli::ServerError since it inherits from Dalli::DalliError.

@nickamorim nickamorim self-assigned this Jan 20, 2025
@nickamorim nickamorim requested a review from grcooper January 20, 2025 14:49
Copy link

@sam-obeid sam-obeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nickamorim nickamorim merged commit 261c452 into main Jan 20, 2025
10 checks passed
@nickamorim nickamorim deleted the nickamorim/unused branch January 20, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants