Merge pull request #38 from Shopify/grcooper/remove-fake-nonblocking

Remove readfull, ruby does nonblocking in C
Shopify · Feb 3, 2025 · 6104ccd · 6104ccd
2 parents 8e8e405 + 59c04ba
commit 6104ccd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/lib/dalli/protocol/connection_manager.rb b/lib/dalli/protocol/connection_manager.rb
@@ -161,7 +161,7 @@ def read_line
       end
 
       def read(count)
-        @sock.readfull(count)
+        @sock.read(count)
       rescue SystemCallError, *TIMEOUT_ERRORS, EOFError => e
         error_on_request!(e)
       end

diff --git a/lib/dalli/socket.rb b/lib/dalli/socket.rb
@@ -15,16 +15,6 @@ module Socket
     module InstanceMethods
       WAIT_RCS = %i[wait_writable wait_readable].freeze
 
-      def readfull(count)
-        value = String.new(capacity: count + 1)
-        loop do
-          result = read_nonblock(count - value.bytesize, exception: false)
-          value << result if append_to_buffer?(result)
-          break if value.bytesize == count
-        end
-        value
-      end
-
       def read_available
         value = +''
         loop do