Skip to content

Bump thiserror from 1.0.64 to 2.0.7 #226

Bump thiserror from 1.0.64 to 2.0.7

Bump thiserror from 1.0.64 to 2.0.7 #226

Triggered via push December 16, 2024 20:35
Status Failure
Total duration 1m 9s
Artifacts

lint.yml

on: push
Matrix: clippy_check
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 19 warnings
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L22
error: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:22:14 | 22 | impl<'de> Visitor<'de> for VersionVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 22 - impl<'de> Visitor<'de> for VersionVisitor { 22 + impl Visitor<'_> for VersionVisitor { |
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L63
error: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:63:14 | 63 | impl<'de> Visitor<'de> for FactorioVersionVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 63 - impl<'de> Visitor<'de> for FactorioVersionVisitor { 63 + impl Visitor<'_> for FactorioVersionVisitor { |
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L106
error: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:106:14 | 106 | impl<'de> Visitor<'de> for DependencyVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 106 - impl<'de> Visitor<'de> for DependencyVisitor { 106 + impl Visitor<'_> for DependencyVisitor { |
clippy_check (stable)
Clippy has exited with exit code 101
clippy_check (nightly)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L22
warning: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:22:14 | 22 | impl<'de> Visitor<'de> for VersionVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 22 - impl<'de> Visitor<'de> for VersionVisitor { 22 + impl Visitor<'_> for VersionVisitor { |
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L63
warning: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:63:14 | 63 | impl<'de> Visitor<'de> for FactorioVersionVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 63 - impl<'de> Visitor<'de> for FactorioVersionVisitor { 63 + impl Visitor<'_> for FactorioVersionVisitor { |
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L106
warning: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:106:14 | 106 | impl<'de> Visitor<'de> for DependencyVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 106 - impl<'de> Visitor<'de> for DependencyVisitor { 106 + impl Visitor<'_> for DependencyVisitor { |
field `mod_info_path` is never read: crates/cli/src/project.rs#L26
warning: field `mod_info_path` is never read --> crates/cli/src/project.rs:26:9 | 14 | pub struct Project { | ------- field in this struct ... 26 | pub mod_info_path: PathBuf, | ^^^^^^^^^^^^^ | = note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
match can be simplified with `.unwrap_or_default()`: crates/cli/src/lib.rs#L56
warning: match can be simplified with `.unwrap_or_default()` --> crates/cli/src/lib.rs:56:55 | 56 | let level_filter = level_filter.unwrap_or_else(|| match config.log_level_filter { | _______________________________________________________^ 57 | | Some(f) => f, 58 | | None => Default::default(), 59 | | }); | |_____^ help: replace it with: `config.log_level_filter.unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`: home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/xshell-0.2.6/src/lib.rs#L348
warning: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits` --> crates/xtask/src/main.rs:33:18 | 33 | dbg!(cmd!(sh, "pwd").read()?); | ^^^^^^^^^^^^^^^ | = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try refering to `cmd` crate for guidance on how handle this unexpected cfg = help: the macro `cmd` may come from an old version of the `xshell` crate, try updating your dependency with `cargo update -p xshell` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default = note: this warning originates in the macro `cmd` (in Nightly builds, run with -Z macro-backtrace for more info)
unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`: home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/xshell-0.2.6/src/lib.rs#L348
warning: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits` --> crates/xtask/src/main.rs:36:13 | 36 | cmd!(sh, "rm -rf target/dist").run()?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try refering to `cmd` crate for guidance on how handle this unexpected cfg = help: the macro `cmd` may come from an old version of the `xshell` crate, try updating your dependency with `cargo update -p xshell` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `cmd` (in Nightly builds, run with -Z macro-backtrace for more info)
unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`: home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/xshell-0.2.6/src/lib.rs#L348
warning: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits` --> crates/xtask/src/main.rs:41:13 | 41 | / ... cmd!( 42 | | ... sh, 43 | | ... "{cargo} build {verbose...} --profile dist --all-features --locked --target {target} --target-dir target/dist --package facti" 44 | | ... ) | |_______^ | = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate = help: try refering to `cmd` crate for guidance on how handle this unexpected cfg = help: the macro `cmd` may come from an old version of the `xshell` crate, try updating your dependency with `cargo update -p xshell` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `cmd` (in Nightly builds, run with -Z macro-backtrace for more info)
clippy_check (stable)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
clippy_check (beta)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L22
warning: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:22:14 | 22 | impl<'de> Visitor<'de> for VersionVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 22 - impl<'de> Visitor<'de> for VersionVisitor { 22 + impl Visitor<'_> for VersionVisitor { |
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L63
warning: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:63:14 | 63 | impl<'de> Visitor<'de> for FactorioVersionVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 63 - impl<'de> Visitor<'de> for FactorioVersionVisitor { 63 + impl Visitor<'_> for FactorioVersionVisitor { |
the following explicit lifetimes could be elided: 'de: crates/lib/src/serde.rs#L106
warning: the following explicit lifetimes could be elided: 'de --> crates/lib/src/serde.rs:106:14 | 106 | impl<'de> Visitor<'de> for DependencyVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 106 - impl<'de> Visitor<'de> for DependencyVisitor { 106 + impl Visitor<'_> for DependencyVisitor { |
field `mod_info_path` is never read: crates/cli/src/project.rs#L26
warning: field `mod_info_path` is never read --> crates/cli/src/project.rs:26:9 | 14 | pub struct Project { | ------- field in this struct ... 26 | pub mod_info_path: PathBuf, | ^^^^^^^^^^^^^ | = note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
match can be simplified with `.unwrap_or_default()`: crates/cli/src/lib.rs#L56
warning: match can be simplified with `.unwrap_or_default()` --> crates/cli/src/lib.rs:56:55 | 56 | let level_filter = level_filter.unwrap_or_else(|| match config.log_level_filter { | _______________________________________________________^ 57 | | Some(f) => f, 58 | | None => Default::default(), 59 | | }); | |_____^ help: replace it with: `config.log_level_filter.unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`: home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs#L348
warning: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits` --> crates/xtask/src/main.rs:33:18 | 33 | dbg!(cmd!(sh, "pwd").read()?); | ^^^^^^^^^^^^^^^ | = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default = note: this warning originates in the macro `cmd` (in Nightly builds, run with -Z macro-backtrace for more info)
unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`: home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs#L348
warning: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits` --> crates/xtask/src/main.rs:36:13 | 36 | cmd!(sh, "rm -rf target/dist").run()?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `cmd` (in Nightly builds, run with -Z macro-backtrace for more info)
unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits`: home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/xshell-0.2.6/src/lib.rs#L348
warning: unexpected `cfg` condition name: `trick_rust_analyzer_into_highlighting_interpolated_bits` --> crates/xtask/src/main.rs:41:13 | 41 | / ... cmd!( 42 | | ... sh, 43 | | ... "{cargo} build {verbose...} --profile dist --all-features --locked --target {target} --target-dir target/dist --package facti" 44 | | ... ) | |_______^ | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trick_rust_analyzer_into_highlighting_interpolated_bits)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: this warning originates in the macro `cmd` (in Nightly builds, run with -Z macro-backtrace for more info)