fix Dojo ComboBox autocomplete param in declarative mode #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a dojo ComboBox form element declaratively, the autocomplete parameter was not properly added as attribute to the html element. This error only occurred when used with a data store. Added test cases accordingly.
develart-projects
added
bug
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Dojo ComboBox form element declaratively, the autocomplete parameter was not properly added as attribute to the html element. This error only occurred when used in combination with a data store.
This fix simply moves up lines 103-106 which address the conversion of the autocomplete parameter to a string.
The early returns in lines 85 and 106 broke this feature for ComboBoxes with a data store.
Added test cases accordingly.