feat(Touchscreen): add support for generic touchscreen devices #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowApex
force-pushed
the
shadowapex/generic-touchscreen
branch
2 times, most recently
from
776e188 to
c0406fc
Compare
|
I'll test this when I get back. |
ShadowApex
force-pushed
the
shadowapex/generic-touchscreen
branch
4 times, most recently
from
07534cb to
f2ba72e
Compare
pastaq
reviewed
Jan 29, 2025
| config: | ||
| touchscreen: | ||
| orientation: "right" | ||
| width: 1280 |
There was a problem hiding this comment.
I think it might be better to use an aspect ratio here and scale it based in the true resolution. We would need to detect that
There was a problem hiding this comment.
I left width and height here to allow users to override the width/height of the virtual touchscreen that gets created, but I have updated this PR to now query the source touchscreen for its size if these are not defined.
ShadowApex
force-pushed
the
shadowapex/generic-touchscreen
branch
from
f2ba72e to
3aed117
Compare
ShadowApex
force-pushed
the
shadowapex/generic-touchscreen
branch
from
3aed117 to
479744d
Compare
|
I'm going to test this on my flip to see if it can fix the bad touchscreen input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for generic touchscreen source devices. This change also adds the
configsection of a source device to allow defining arbitrary configuration of that captured source device. i.e. in the case of touchscreens, it can allow the source driver to translate touches based on the orientation of the touchscreen.