Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm/kwon hj #14

Merged
merged 7 commits into from
Feb 21, 2021
Merged

Algorithm/kwon hj #14

merged 7 commits into from
Feb 21, 2021

Conversation

KimKwon
Copy link
Collaborator

@KimKwon KimKwon commented Feb 13, 2021

변경 사항

Issue 참고 : Note Status Check

  1. 최장 증가 부분수열 (완전탐색) 구현
  2. 최장 증가 부분수열 (동적계획법) 이론 & 구현
  3. 최장 증가 부분수열 (이분탐색) 이론 & 구현

Point of discussion

코드는 BOJ에서 동작 여부 확인 후 업로드했습니다!
완전탐색 같은 경우에는 이론에 대한 언급을 거의 하지 않았으므로.. 구현만 한 것으로~

Reference

Copy link
Owner

@Seogeurim Seogeurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번에 발표 들으면서 LIS 관련 문제들을 dp가 아닌 이분탐색으로 풀어보며 쾌감을 느꼈습니다 ㅎㅎㅎ
나중에 까먹으면 또 보러올게요 !!


if(dp[i] > top) {
top = dp[i];
top_i = i;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 top_i는 무슨 용도인가요 ~? LIS 원소를 구할 때 사용하는 변수인가요? 뒤에서 출력은 안 되는 것 같은데 주석 등으로 설명이 있다면 좋을 것 같아요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIS 요소를 출력하는데에 쓰이는 인덱스 변수인데 제가 밑에 코드를 누락시킨 것 같네요
추가시켜서 커밋 작성했습니다!
7eb1d51 👍

Copy link
Collaborator

@Hee-Jae Hee-Jae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower bound 직접 구현해서 사용한게 참 인상적이네요^^ 직접 구현하면 뭔가 뿌듯해져요.

Copy link
Collaborator

@yoongoing yoongoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

명강의였습니다. 저도 곧 콘텐츠 업로드하겠습니다.

@yoongoing yoongoing merged commit 2234f1d into main Feb 21, 2021
@KimKwon
Copy link
Collaborator Author

KimKwon commented Feb 22, 2021

권혁진: (구현3 + 이론2) = +60점
윤가영,서그림,정희재: PR리뷰자 = +5점씩

@Seogeurim Seogeurim added the score OK Score Board에 점수 반영 완료 label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
score OK Score Board에 점수 반영 완료
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants