Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): add partial scheduling based on min replicas #6221

Open
wants to merge 12 commits into
base: v2
Choose a base branch
from

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Jan 23, 2025

What this PR does / why we need it:
This PR introduces the ability to do partial scheduling for a given model if:

  • The number of replicas for all candidate servers is less than the desired replica of the model
  • The min replicas of the model is less than the available replicas of the server to load the model onto

In this case we load the model on as many replicas as possible, and also mark the model as ScheduleFailed.

We also favour servers that have the models loaded to minimise ping-ping behaviour.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sakoush sakoush added the v2 label Jan 23, 2025
@sakoush sakoush marked this pull request as ready for review January 24, 2025 09:44
@sakoush sakoush requested a review from lc525 as a code owner January 24, 2025 09:44
@sakoush sakoush requested review from driev and removed request for lc525 January 24, 2025 09:54
scheduler/pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants