Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply minor formatting and error capturing changes. Update README. #2

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Sep 26, 2017

I was able to get autocomplete working with the instructions in the updated README (and should hopefully address #1).

I also added some code to the parsing to (a) use argparse only and (b) by default compare to the merge-base between the destination branch (HEAD if none) and master.

@SeanCurtis-TRI Would you be able to give this a spin and see if it works for you?


This change is Reviewable

@SeanCurtis-TRI
Copy link
Owner

This is excellent. Thanks for doing this. :LGTM:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


drake_cloc.py, line 218 at r1 (raw file):

        src_name = "$({})".format(cmd)

    print("Computing difference between %s and %s.\n"

BTW You've upgraded this print statement to python 3, but not the previous. Any particular reason?


Comments from Reviewable

@SeanCurtis-TRI SeanCurtis-TRI merged commit bbd2753 into master Oct 2, 2017
@EricCousineau-TRI
Copy link
Collaborator Author

drake_cloc.py, line 218 at r1 (raw file):

Previously, SeanCurtis-TRI (Sean Curtis) wrote…

BTW You've upgraded this print statement to python 3, but not the previous. Any particular reason?

Er, not really. Just missed it - sorry about that!


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants