Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sort settings in detect after adding special settings. #196

Merged
merged 1 commit into from
Jul 31, 2024

Fix: sort settings in detect after adding special settings.

61f0855
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix: sort settings in detect after adding special settings. #196

Fix: sort settings in detect after adding special settings.
61f0855
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy failed Jul 31, 2024 in 1s

clippy

7 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 7
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 735 in src/commands/edge_app.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> src/commands/edge_app.rs:728:9
    |
728 | /         match InstanceManifest::new(path) {
729 | |             Ok(manifest) => {
730 | |                 if manifest.id.is_some() {
731 | |                     return Err(CommandError::InstanceAlreadyExists);
...   |
734 | |             Err(_) => {}
735 | |         }
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `-D clippy::single-match` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::single_match)]`
help: try
    |
728 ~         if let Ok(manifest) = InstanceManifest::new(path) {
729 +             if manifest.id.is_some() {
730 +                 return Err(CommandError::InstanceAlreadyExists);
731 +             }
732 +         }
    |

Check failure on line 137 in src/commands/instance_manifest.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `ensure_manifest_is_valid` is never used

error: associated function `ensure_manifest_is_valid` is never used
   --> src/commands/instance_manifest.rs:137:12
    |
112 | impl InstanceManifest {
    | --------------------- associated function in this implementation
...
137 |     pub fn ensure_manifest_is_valid(path: &Path) -> Result<(), CommandError> {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 13 in src/commands/edge_app_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

constant `RESERVED_SETTING_NAMES` is never used

error: constant `RESERVED_SETTING_NAMES` is never used
  --> src/commands/edge_app_settings.rs:13:7
   |
13 | const RESERVED_SETTING_NAMES: &[&str] = &[
   |       ^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 120 in src/commands/edge_app_manifest.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `default_syntax` is never used

error: function `default_syntax` is never used
   --> src/commands/edge_app_manifest.rs:120:4
    |
120 | fn default_syntax() -> String {
    |    ^^^^^^^^^^^^^^

Check failure on line 1319 in src/commands/edge_app.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `get_actual_app_id` is never used

error: method `get_actual_app_id` is never used
    --> src/commands/edge_app.rs:1319:12
     |
805  | impl EdgeAppCommand {
     | ------------------- method in this implementation
...
1319 |     pub fn get_actual_app_id(
     |            ^^^^^^^^^^^^^^^^^

Check failure on line 118 in src/commands/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variant `EmptyAppId` is never constructed

error: variant `EmptyAppId` is never constructed
   --> src/commands/mod.rs:118:5
    |
82  | pub enum CommandError {
    |          ------------ variant in this enum
...
118 |     EmptyAppId,
    |     ^^^^^^^^^^
    |
    = note: `CommandError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

Check failure on line 195 in src/commands/edge_app.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

error: variable does not need to be mutable
   --> src/commands/edge_app.rs:195:13
    |
195 |         let mut manifest = EdgeAppManifest::new(&manifest_path)?;
    |             ----^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `-D unused-mut` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_mut)]`