Clarify how to update the secret value #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My intuition tells me I must set the secret value in the config file, but that's wrong. In the help text, I clarify how to instantiate the secret value.
|
It is good to add in the documentation, though I don't think secret would be ever set in the config - also same applies to the setting - and we want to merge them as well - it all will be just setting command. |
|
@renatgalimov I don't think the PR is still relevant with the changes in dev-branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intuition tells me I must set the secret value in the config file, but that's wrong.
In the help text, I clarify how to instantiate the secret value.
Checklist before merging