Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/installation id manifest #160

Merged
merged 5 commits into from
May 8, 2024

Conversation

korvyashka
Copy link
Contributor

Bringing installation_id back, cause now we could have multiple installation in the UI.

For compatability with old yamls without installation_id, cli, when needed, will request(or create) and save installation_id using deprecated name 'Edge app cli installation'.
So eventually yaml file must have installation_id to work properly.

Other changes

  • Installation of an app moved from upload to edge app create command.
  • For some commands now installation_id is required either by passing as argument or in the manifest.
    • Promote command(to check undefined settings)
    • All settings commands
    • Secret set command

@korvyashka
Copy link
Contributor Author

TODO: update commands to have only installation_id passed as argument when both are required.

src/cli.rs Outdated Show resolved Hide resolved
@korvyashka korvyashka merged commit 45c5074 into master May 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants