Merge pull request #195 from Screenly/fix/version_comparison #504
Annotations
8 errors and 2 warnings
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/commands/edge_app.rs#L728
error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/commands/edge_app.rs:728:9
|
728 | / match InstanceManifest::new(path) {
729 | | Ok(manifest) => {
730 | | if manifest.id.is_some() {
731 | | return Err(CommandError::InstanceAlreadyExists);
... |
734 | | Err(_) => {}
735 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `-D clippy::single-match` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_match)]`
help: try
|
728 ~ if let Ok(manifest) = InstanceManifest::new(path) {
729 + if manifest.id.is_some() {
730 + return Err(CommandError::InstanceAlreadyExists);
731 + }
732 + }
|
|
associated function `ensure_manifest_is_valid` is never used:
src/commands/instance_manifest.rs#L137
error: associated function `ensure_manifest_is_valid` is never used
--> src/commands/instance_manifest.rs:137:12
|
112 | impl InstanceManifest {
| --------------------- associated function in this implementation
...
137 | pub fn ensure_manifest_is_valid(path: &Path) -> Result<(), CommandError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
constant `RESERVED_SETTING_NAMES` is never used:
src/commands/edge_app_settings.rs#L13
error: constant `RESERVED_SETTING_NAMES` is never used
--> src/commands/edge_app_settings.rs:13:7
|
13 | const RESERVED_SETTING_NAMES: &[&str] = &[
| ^^^^^^^^^^^^^^^^^^^^^^
|
function `default_syntax` is never used:
src/commands/edge_app_manifest.rs#L120
error: function `default_syntax` is never used
--> src/commands/edge_app_manifest.rs:120:4
|
120 | fn default_syntax() -> String {
| ^^^^^^^^^^^^^^
|
method `get_actual_app_id` is never used:
src/commands/edge_app.rs#L1319
error: method `get_actual_app_id` is never used
--> src/commands/edge_app.rs:1319:12
|
805 | impl EdgeAppCommand {
| ------------------- method in this implementation
...
1319 | pub fn get_actual_app_id(
| ^^^^^^^^^^^^^^^^^
|
variant `EmptyAppId` is never constructed:
src/commands/mod.rs#L118
error: variant `EmptyAppId` is never constructed
--> src/commands/mod.rs:118:5
|
82 | pub enum CommandError {
| ------------ variant in this enum
...
118 | EmptyAppId,
| ^^^^^^^^^^
|
= note: `CommandError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
variable does not need to be mutable:
src/commands/edge_app.rs#L195
error: variable does not need to be mutable
--> src/commands/edge_app.rs:195:13
|
195 | let mut manifest = EdgeAppManifest::new(&manifest_path)?;
| ----^^^^^^^^
| |
| help: remove this `mut`
|
= note: `-D unused-mut` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_mut)]`
|
Lint code base
Clippy had exited with the 101 exit code
|
Lint code base
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Lint code base
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|