Skip to content

Merge pull request #191 from Screenly/feature/update_entrypoint #499

Merge pull request #191 from Screenly/feature/update_entrypoint

Merge pull request #191 from Screenly/feature/update_entrypoint #499

Triggered via push July 19, 2024 09:27
Status Failure
Total duration 1m 58s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 2 warnings
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: src/commands/edge_app.rs#L738
error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/commands/edge_app.rs:738:9 | 738 | / match InstanceManifest::new(path) { 739 | | Ok(manifest) => { 740 | | if manifest.id.is_some() { 741 | | return Err(CommandError::InstanceAlreadyExists); ... | 744 | | Err(_) => {} 745 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `-D clippy::single-match` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_match)]` help: try | 738 ~ if let Ok(manifest) = InstanceManifest::new(path) { 739 + if manifest.id.is_some() { 740 + return Err(CommandError::InstanceAlreadyExists); 741 + } 742 + } |
associated function `ensure_manifest_is_valid` is never used: src/commands/instance_manifest.rs#L137
error: associated function `ensure_manifest_is_valid` is never used --> src/commands/instance_manifest.rs:137:12 | 112 | impl InstanceManifest { | --------------------- associated function in this implementation ... 137 | pub fn ensure_manifest_is_valid(path: &Path) -> Result<(), CommandError> { | ^^^^^^^^^^^^^^^^^^^^^^^^
constant `RESERVED_SETTING_NAMES` is never used: src/commands/edge_app_settings.rs#L13
error: constant `RESERVED_SETTING_NAMES` is never used --> src/commands/edge_app_settings.rs:13:7 | 13 | const RESERVED_SETTING_NAMES: &[&str] = &[ | ^^^^^^^^^^^^^^^^^^^^^^
function `default_syntax` is never used: src/commands/edge_app_manifest.rs#L120
error: function `default_syntax` is never used --> src/commands/edge_app_manifest.rs:120:4 | 120 | fn default_syntax() -> String { | ^^^^^^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]`
Lint code base
Clippy had exited with the 101 exit code
Lint code base
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Lint code base
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/