Adapt to systemd and reconfigure a working display manager. #14
Conversation
After removal we need to make sure that at least any WM is configured.
After removal we need to make sure that at least any WM is configured.
postrm: Remvove nodm from runlevel. postrm: Restart DM after removeal. postrm: Stop nodm bevore restarting new default dm. postrm: Stop nodm first.
Suppress Lintian error on removal of nodm from runlevel.
Conflicts: DEBIAN/postrm
| @@ -11,6 +12,16 @@ case "$1" in | |||
| db_purge | |||
| fi | |||
| rm -f /usr/sbin/kiosk-browser | |||
| # In a perfect world, this should also care for lightdm xdm wdm slim lxdm gdm etc... | |||
| WMS=`dpkg-query -W -f='Package: ${Package}\nProvides: ${Provides}\n' | grep -B 1 -E "^Provides: .*x-display-manager" | grep Package | cut -d" " -f2` | |||
There was a problem hiding this comment.
Please use $() instead. Instead of this search logic, why not simply remember the previous setting in /etc/X11/default-display-manager.pre-kiosk-browserand simply restore it upon removal?
There was a problem hiding this comment.
The user could have removed a DM which was configured at install-time. Remembering this would not lead to a working DM.
Will change `` to $()
There was a problem hiding this comment.
If the user breaks it he will fix it. I really don't like this lookup into
tha package database for this purpose. I also think that this is less
likely scenario and that at the most a user will just remove kiosk-browser
and be happy to go back to the previous configuration.
On 13 October 2015 at 14:03, MartinLinSup [email protected] wrote:
In DEBIAN/postrm
#14 (comment)
:@@ -11,6 +12,16 @@ case "$1" in
db_purge
fi
rm -f /usr/sbin/kiosk-browser
In a perfect world, this should also care for lightdm xdm wdm slim lxdm gdm etc...
- WMS=
dpkg-query -W -f='Package: ${Package}\nProvides: ${Provides}\n' | grep -B 1 -E "^Provides: .*x-display-manager" | grep Package | cut -d" " -f2The user could have removed a DM which was configured at installtime.
Remebering this would not lead to a working DM.Will change `` to $()
—
Reply to this email directly or view it on GitHub
https://github.com/ImmobilienScout24/kiosk-browser/pull/14/files#r41857053
.
No description provided.