Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues by updating bundler before install per rubygems/rubygems/issues/1419 #37

Merged
merged 2 commits into from
Jun 22, 2016

Conversation

envp
Copy link
Member

@envp envp commented Feb 14, 2016

Currently travis builds for distribution are failing due to an outdated bundler being used as the default one by travis. This is explained rubygems/rubygems/issues/1419. This PR's objective is to fix this issue and see if the following dependant PRs pass their respective tests (which they should)

PRs whose test status will be affected by this

  1. Complete binomial dist #33
  2. Update README.md to match current implementation #34
  3. Update README : Update Ubuntu/Debian gsl package name. #35
  4. Random number generator for Gamma And Beta function  #36
  5. Remove unnecessary computation #38

Due to this dependency, it is better if this PR is merged prior to any of its dependents.

Ruby 1.9.3 seems to be stalled now (2 and 2.2 have passed) @agarie @clbustos can you please check?

@i2000s
Copy link

i2000s commented Feb 14, 2016

Thanks for doing this! I have seen & experienced a lot of troubles due to the outdated bundler. I am not qualified to review this PR, but encourage experts to double check this work sooner than later.

@translunar translunar merged commit d2d306f into SciRuby:master Jun 22, 2016
@envp envp deleted the fix_travis_build_issues branch June 22, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants