Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwargs are passed when converting ODEProblem to SteadyStateProblem and NonlinearProblem #524

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

yonatanwesen
Copy link
Contributor

@yonatanwesen yonatanwesen commented Oct 17, 2023

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #524 (2c13b5d) into master (7afe983) will decrease coverage by 18.85%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #524       +/-   ##
===========================================
- Coverage   47.36%   28.51%   -18.85%     
===========================================
  Files          53       53               
  Lines        3921     3896       -25     
===========================================
- Hits         1857     1111      -746     
- Misses       2064     2785      +721     
Files Coverage Δ
src/problems/basic_problems.jl 78.75% <100.00%> (-1.25%) ⬇️
src/problems/steady_state_problems.jl 83.33% <100.00%> (ø)

... and 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 578352c into SciML:master Oct 17, 2023
63 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SteadyState/Nonlinear)Problems from ODEProblems ignore kwargs
2 participants