Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex2.1 #343

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Complex2.1 #343

merged 5 commits into from
Dec 5, 2023

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Dec 5, 2023

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the ScioML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

xtalax and others added 5 commits December 5, 2023 18:56
* encapsulating basic functionality of construct_discrete_space to make it easier to extend/specialize on grid type

* adding staggered grid type

* overloading transform_pdesys (and unfortunately for now symbolic_discretize, but this shouldn't be necessary in general) to get spatial staggering working. very close now, just need to tease out the details of the discretized differential operators now.

* this commit should be reverted, this is debug code that I want to have available elsewhere

* removing symbolic discretize specialization, think we have a better path forward specializing only low-level differential discretizer methods

* implementing centered finite difference for staggered grid\!

* fixes to resolve off-by-one error in staggered solve of wave equation

* working staggered boundary conditions

* specializing SciMLBase.discretize to put staggered discretizations into DynamicalODEProblem

* tucking DynamicalODEProblem inside discretize, so removing it from example code

* successfully returning DynamicalODEProblem from discretize

* a bit of massaging, simplyfying, poking at generality

* removing debug code

* formulating guiding examples as tests

* generalizing symbolic tracing operation

* framing hack fixing changes

* upstream pipelining just about done, need to check constructor works correctly and staggered data is available in DiscreteSpace object

* DiscreteSpace now holds staggered dictionary created from staggered discretization kwarg

* finished removing hacks, put in proper logic, beginning to add tests

* adding staggered tests to runtests

* adding additional tests...currently doesn't work

* updating staggered discretize to output split ode system compatible with OTS solvers

* removing duplicate/ambiguous code

* correcting transparent boundary conditions, updating solution format to work with revised output from discretize

* updating test to use splitode solution interface

* no change, trying to trigger github actions

* adding staggered wave equation tests to CI

* fixing precompilation bug, vars->vars.intervals

* remedying includes

* adding required includes, correcting test bug

* adding docs file for staggered grids

* marking nonlinear laplacian tests as broken - directed by Alex for a known upstream issue

* removing  from heat equation example due to upstream failing code

* dummy commit to trigger CI

* dummy commit to trigger CI

* Update Project.toml

---------

Co-authored-by: chyett home <[email protected]>
Co-authored-by: Criston Hyett <[email protected]>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (505cd38) 82.55% compared to head (cef726d) 84.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   82.55%   84.99%   +2.44%     
==========================================
  Files          41       41              
  Lines        1960     1959       -1     
==========================================
+ Hits         1618     1665      +47     
+ Misses        342      294      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xtalax xtalax merged commit 34634e0 into SciML:master Dec 5, 2023
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant