-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stencil Interface #187
base: stencils
Are you sure you want to change the base?
Stencil Interface #187
Conversation
typo with comma and no x defined
Allow integer dx to discretize dimension in to that number of points
Codecov Report
@@ Coverage Diff @@
## stencils #187 +/- ##
============================================
- Coverage 80.48% 78.58% -1.91%
============================================
Files 35 37 +2
Lines 1681 1840 +159
============================================
+ Hits 1353 1446 +93
- Misses 328 394 +66
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is there any estimation on how this change to the discrimination formulation will affect the sizes of domains we can work with? The 2 d domain that i consider takes several minutes to discretize for only 30 x 30. Im curious about what the capabilities of MOL will be after this change goes through. Thank you all for your work on this package! |
There was a misspelling of DomainSets
Update boundary_conditions.md
Recursively unwrap equations
@gladisor The essential idea is that once this is pushed and the infrastructure in MTK is done, discretization and compile time will be O(1), domain size will no longer have an effect. It will be entirely dependent on the complexity of the PDESystem itself. Early experiments suggest that this method even improves upon discretization time for low N problems |
* [skip ci] LanguageTool * upgrade Symbolics and SymbolicUtils * upgrade mtk * revert * update bounds * fix errors * fix test * fix test 1.6 * more fixes * typo * fix docs * bump scimlbase * Update Project.toml * chebyspace * test * link * correct inf sup * don't reassign var name * snap ends to ends * passing * fix example * test cheby ex * Update Project.toml --------- Co-authored-by: ArnoStrouwen <[email protected]> Co-authored-by: Christopher Rackauckas <[email protected]>
Is there an estimate of the remaining work or time required to complete this PR? |
Start work on using the stencil interfaces, the result will be scalarized for now until MTK supports array equations. Since this will not give much advantage for now, the changes will be pushed to the stencils branch.
fixes #196
fixes #40
fixes #93