Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configuration parsing option and add configuration structure using dataclass. #9

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

YooSunYoung
Copy link
Contributor

Fixes #8

Main Updates

It is mostly copied-pasted from the original code.
I adjusted some names and made the option-names consistent between configuration file and argument parser.
The result of the argument/configuration parsing is now a dataclass so that
it's easier to access to each options in other functions.

Tests

  • options in the configuration file and argument parsed options have consistent names
  • The configuration template have all possible options.
  • Run-time arguments overwrite the configuration file options correctly.
  • The original option dictionary is read-only.

@YooSunYoung YooSunYoung changed the base branch from master to main April 5, 2024 12:22
@YooSunYoung YooSunYoung added this to the Refactoring milestone Apr 5, 2024
@YooSunYoung YooSunYoung requested a review from nitrosx April 5, 2024 12:37
@YooSunYoung YooSunYoung enabled auto-merge April 5, 2024 12:41
@YooSunYoung YooSunYoung changed the base branch from main to update-python-version April 19, 2024 13:16
@YooSunYoung YooSunYoung disabled auto-merge April 19, 2024 13:24
Base automatically changed from update-python-version to main April 19, 2024 13:25
@YooSunYoung YooSunYoung enabled auto-merge April 19, 2024 13:48
@YooSunYoung YooSunYoung merged commit 2f1cbee into main Apr 23, 2024
2 checks passed
@YooSunYoung YooSunYoung deleted the configuration branch April 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactoring] Configuration parsing.
2 participants