Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dataset by job id and metadata #75

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

YooSunYoung
Copy link
Contributor

Rewrote #58

@nitrosx I rewrote them to use dataclass instead of plain dictionary.

@YooSunYoung YooSunYoung requested a review from nitrosx October 1, 2024 09:48
Copy link
Contributor

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the 3 comments are addressed, we are good to merge

src/scicat_communication.py Outdated Show resolved Hide resolved
src/scicat_communication.py Outdated Show resolved Hide resolved
src/scicat_communication.py Show resolved Hide resolved
@YooSunYoung YooSunYoung requested a review from nitrosx October 2, 2024 08:26
@YooSunYoung YooSunYoung force-pushed the check-dataset-by-job-id-2 branch from b3705b4 to cce2dae Compare October 2, 2024 08:26
@YooSunYoung YooSunYoung enabled auto-merge October 2, 2024 08:26
@YooSunYoung YooSunYoung merged commit abf6876 into main Oct 28, 2024
3 checks passed
@YooSunYoung YooSunYoung deleted the check-dataset-by-job-id-2 branch October 28, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants