Added the possibility to unroll the scientific metadata tree from a particular point #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting back in line with the main pyscicat base
|
probably a rebase |
dylanmcreynolds
requested changes
Oct 31, 2023
| @@ -92,7 +92,7 @@ def unwind( | |||
|
|
|||
|
|
|||
| def scientific_metadata( | |||
| filename, excludeRootEntry: bool = True, skipKeyList: list = [] | |||
| filename, excludeRootEntry: bool = True, skipKeyList: list = [], startPath:str="/" | |||
There was a problem hiding this comment.
flake8 is probably going to want spaces around the =
|
Tests are failing on this. Is this something you still want to work on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option "startPath" has been added to scientific_metadata in case you don't want the entire tree from "/" to be ingested. This can be helpful, for example, when you are storing raw, processed and analysed data in a single file and only want to catalog the analysis.