Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): disable postcss plugin calc to resolve issue caused by onyx using the calc-constant infinity #1261

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

markbrockhoff
Copy link
Member

Building a nuxt project using the module would just hang up due to an issue within the postcss plugin "calc" used by nanocss which is used by nuxt's default postcss config.
This fix simply disables the plugin for nuxt projects using the module for now. An issue was created for the postcss plugin (see: postcss/postcss-calc#210)

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • [y] If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@markbrockhoff markbrockhoff requested a review from a team as a code owner June 7, 2024 11:13
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: daa5f71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sit-onyx/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert merged commit 585f2f5 into main Jun 7, 2024
19 checks passed
@larsrickert larsrickert deleted the nuxt/fix-build branch June 7, 2024 11:44
@markbrockhoff markbrockhoff mentioned this pull request Jun 7, 2024
4 tasks
larsrickert pushed a commit that referenced this pull request Jun 7, 2024
Relates to #1261 

After fixing the build sadly the dev mode got broken by the postcss
config. This PR fixes that by explicitly overwriting the cssnano config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants