Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Disabled semicolons #55

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: Disabled semicolons #55

merged 1 commit into from
Apr 24, 2024

Conversation

LobeTia
Copy link
Member

@LobeTia LobeTia commented Apr 13, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Prettier default adds semicolon, but we're in 2024, no time for semicolons
Disabled option by configuration and re-linted everything

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@LobeTia LobeTia changed the title chore: Disabled semicolons in all project chore: Disabled semicolons Apr 13, 2024
@TheJoin95
Copy link
Member

Maybe a rebase is needed

@LobeTia LobeTia merged commit 61d1cf3 into main Apr 24, 2024
1 check failed
@LobeTia LobeTia deleted the chore/prettier-no-semicolon branch April 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJoin95 TheJoin95 TheJoin95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LobeTia @TheJoin95