Update client with argparse (#3) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: please update to the latest image-go-nord package version |
BugliL
force-pushed
the
main
branch
3 times, most recently
from
94350ff to
1a4e4c8
Compare
Wabri
reviewed
Jul 9, 2024
| OUTPUT_IMAGE_NAME = "nord" + DEFAULT_EXTENSION | ||
|
|
||
| __doc__ = """ImageGoNord, a converter for a rgb images to norththeme palette. | ||
| Usage: gonord [OPTION]... |
There was a problem hiding this comment.
Maybe better:
Suggested change
| Usage: gonord [OPTION]... | |
| Usage: ign [OPTION]... |
did we decided to reduce the command to something thin like ign in the end? Or is it still a point for discussion? I dont have a good memory and don't find where we had the discussion 😁
There was a problem hiding this comment.
Good idea, but I think this is better in another PR
Test added: No avg pixel Test added: No avg pixel refactor: moved old tests feat: added settings for vscode refactor: moved tests refactor: moving files test: creating mocked tests test: first mocked test test: added base tests test: full mock feat: added wrong parameter refactor: removed useless params refactor: tests + main refactor: introducing argparse refactor: using sys.stderr for img and version refactor: quiet mode refactor: output file refactor: no-avg refactor: blur and logging refactor: black refactor: pixels-area refactor: small fixes refactor: small fixes refactor: moving to __init__ refactor: pattern selection refactor: version refactor: updated readme feat: updated readme feat: updated readme
refactor(palette): tests feat(palette): updated version
Co-authored-by: GabrielePuliti <[email protected]>
Open
|
I'll leave the honor to @BugliL for his great and huge work! |
What do you mean? Just a simple run with the result? |
|
Exactly |
|
> python src/image_go_nord_client -i ~/Pictures/Screenshots/profile.png --palette nord -o ./nord.png
> python src/image_go_nord_client -i ~/Pictures/Screenshots/profile.png --palette serenade -o ./serenade.png |
|
You can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Rewrited part of the client using argparse.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
All instruction to test this code is written in the
README.mdfile.All tests are in the folder
tests/Test Configuration:
Checklist: