Improve stability of binary_hard_sphere for low q #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets binary hard sphere form factor to limit value for small q. This hides the numerical instability without fixing it.
I tested various large sphere radii (1000, 100, 10) and various sphere ratios (1:1.001, 1:4, 1:10, 1:100). There are still some places where the cutoff is too low (with noise showing up at low q) or too high (abrupt jump to the limit).
Please check that reasonable values of radii are supported, and record them in the model documentation. Also check a range of volume fractions.
Refs #306