V3.1.0 #6
Open
V3.1.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if isinstance(e, AccessTokenRefreshError): | ||
| error += _(' Try to <a href="%s">revoke and grant access</a> again') % reverse('jet-dashboard:update_module', kwargs={'pk': self.model.pk}) | ||
| error += _(' Try to <a href="%s">revoke and grant access</a> again') % reverse( |
There was a problem hiding this comment.
These too needs to use .format instead
| return False | ||
| elif self.counter is None: | ||
| self.error = mark_safe(_('Please <a href="%s">select Google Analytics counter</a> to start using widget') % reverse('jet-dashboard:update_module', kwargs={'pk': self.model.pk})) | ||
| self.error = mark_safe( | ||
| _('Please <a href="%s">select Google Analytics counter</a> to start using widget') |
There was a problem hiding this comment.
These too needs to use .format instead
| group = "day" | ||
| return self.api_request( | ||
| "stat/traffic/summary.json?id=%s&date1=%s&date2=%s&group=%s" | ||
| % (counter, date1.strftime("%Y%m%d"), date2.strftime("%Y%m%d"), group) |
There was a problem hiding this comment.
Here too .format needs to be used
| self.set_counter_choices(module) | ||
|
|
||
| def set_counter_choices(self, module): | ||
| counters = module.counters() | ||
| if counters is not None: | ||
| self.fields['counter'].choices = (('', '-- %s --' % force_str(_('none'))),) | ||
| self.fields['counter'].choices.extend(map(lambda x: (x['id'], x['site']), counters)) | ||
| self.fields["counter"].choices = (("", "-- %s --" % force_str(_("none"))),) |
There was a problem hiding this comment.
Here too .format or f
| '<a href="%s">attach Yandex account and choose Yandex Metrika counter</a> ' | ||
| "to start using widget" | ||
| ) | ||
| % reverse("jet-dashboard:update_module", kwargs={"pk": self.model.pk}) |
| self.stdout.write(' ]),') | ||
| self.stdout.write(" ('%s', [" % app_label) | ||
| for model in app["models"]: | ||
| self.stdout.write(" '%s'," % model["object_name"]) |
There was a problem hiding this comment.
here too .format or f
| self.stdout.write(' {\'app_label\': \'%s\', \'items\': [' % ( | ||
| app['app_label'] | ||
| )) | ||
| self.stdout.write(" {'app_label': '%s', 'items': [" % (app["app_label"])) |
There was a problem hiding this comment.
here too .format or f
| model['name'] | ||
| )) | ||
| for model in app["models"]: | ||
| self.stdout.write(" {'name': '%s'}," % (model["name"])) |
There was a problem hiding this comment.
and here too .format or f
| @@ -21,8 +21,8 @@ class SearchableTestModel(models.Model): | |||
| field2 = models.IntegerField() | |||
|
|
|||
| def __str__(self): | |||
| return '%s%d' % (self.field1, self.field2) | |||
| return "%s%d" % (self.field1, self.field2) | |||
There was a problem hiding this comment.
here too .format or f
| field2 = 2 | ||
| pinned_application = TestModel.objects.create(field1=field1, field2=field2) | ||
| self.assertEqual(get_model_instance_label(pinned_application), '%s%d' % (field1, field2)) | ||
| self.assertEqual(get_model_instance_label(pinned_application), "%s%d" % (field1, field2)) |
There was a problem hiding this comment.
here too .format or f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.