Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BDI_DataImportService_TEST to fix the issues with Platform Encryption enabled users #7276

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Update BDI_DataImportService_TEST to fix the issues with Platform Encryption enabled users #7276

merged 5 commits into from
Jan 8, 2025

Conversation

salesforce-suyash-more
Copy link
Contributor

GUS: W-17550754

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

force2b
force2b reviewed Jan 7, 2025
View reviewed changes
force-app/main/default/classes/BDI_DataImportService_TEST.cls Outdated
List<Id> createdAccountIds = new List<Id>();
List<Id> createdContactIds = new List<Id>();

// Insert Accounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove all the fields and other logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reverted the earlier changes and committed a new one.

@force2b
Copy link
Contributor

force2b commented Jan 8, 2025

Testing:

  • Using CCI, I created a new Scratch org (updating the Features list in the scratch org configuration to include "PlatformEncryption")
  • Deploy all code into the org
  • Use CCI to run the config_platformencryption flow - which enables and fully configures Platform Encryption in the scratch org for testing
  • Execute all unit tests including the modified test to validate that all tests succeeded

image

@daniel-fuller daniel-fuller self-requested a review January 8, 2025 14:08
@daniel-fuller
Copy link
Contributor

@salesforce-suyash-more you will need to change the base branch for this PR to main

@force2b
Copy link
Contributor

force2b commented Jan 8, 2025

@salesforce-suyash-more you will need to change the base branch for this PR to main

Great catch!!

@force2b
Copy link
Contributor

force2b commented Jan 8, 2025

This also needs to get checked in today.

@force2b
Copy link
Contributor

force2b commented Jan 8, 2025

@salesforce-suyash-more I'm seeing one failing test:

--------------------------------------------------------------------------------                                                                    
                    Failing Tests                                                                                                                                       
                    --------------------------------------------------------------------------------                                                                    
                    1: BDI_DataImportCTRL_TEST.testSelectedDIDryRun - Fail                                                                                              
                            Message: System.AssertException: Assertion Failed: Same value: null                                                                         
                            StackTrace: Class.BDI_DataImportCTRL_TEST.testSelectedDIDryRun: line 303, column 1

@daniel-fuller daniel-fuller removed their request for review January 8, 2025 15:18
@daniel-fuller daniel-fuller self-assigned this Jan 8, 2025
@daniel-fuller daniel-fuller changed the base branch from feature/256 to main January 8, 2025 15:27
@daniel-fuller daniel-fuller force-pushed the feature/256__W-17550754-Update-BDI_DataImportService_TEST branch from 40cd7aa to e0d8235 Compare January 8, 2025 15:51
@daniel-fuller daniel-fuller requested a review from lparrott January 8, 2025 19:27
lparrott
lparrott approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@lparrott lparrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@daniel-fuller daniel-fuller merged commit c5fb4eb into main Jan 8, 2025
8 of 13 checks passed
@daniel-fuller daniel-fuller deleted the feature/256__W-17550754-Update-BDI_DataImportService_TEST branch January 8, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lparrott lparrott lparrott approved these changes

@force2b force2b force2b approved these changes

Assignees

@daniel-fuller daniel-fuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salesforce-suyash-more @force2b @daniel-fuller @lparrott