Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Robot] Adding a shell script to support the creation of regression and qa orgs #5984

Open
wants to merge 272 commits into
base: main
Choose a base branch
from

Conversation

rjanjanam
Copy link
Contributor

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

New Metadata

Deleted Metadata

@rjanjanam rjanjanam changed the title Adding a shell script to support the creation of regression or qa orgs [Robot] Adding a shell script to support the creation of regression and qa orgs Oct 26, 2020
@rjanjanam rjanjanam requested a review from rhakeshj October 26, 2020 16:56
@rjanjanam rjanjanam self-assigned this Oct 26, 2020
@rjanjanam rjanjanam added the WIP Work in Progress label Oct 26, 2020
function help {
echo "**This is script written to help QE manage scratch org either for testing or regression purpose **"
echo "Below Options can be provided:"
echo ' \t '"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it missing -e interpreter?

-a action to perform [create/delete/list/info ]
-p additional actions to create an additional usre or to enable rd2 within the org [createuser/rd2] "

echo "Create a new org or rebuild an org : ./manage_scratchorg.sh [-o org] [-n orgname] [-f feature] [-d days] [-a create]"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a uniform file name across the script? I see manage_scratchorg.sh in some and manage_org.sh in some

function createusage {

echo "usage: ./manage_scratchorg.sh [-o org] [-n orgname] [-f feature] [-d days] [-a action]"
echo "Example: ./manage_org.sh -o dev -n testrj -f regression -d 5 -a create"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the example org name to reflect the note in next line?

}
function deleteusage {
clear
echo "\nusage: ./manage_scratchorg.sh [-n orgname] [-a action]"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Missing -e

function deleteorg {
clear
count=`cci org list | grep -i -w $orgname | wc -l`
if [[ "$count" -ne 1 ]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong here. Irrespective of count check, cci commands to delete scratch org will run. Can we put that inside else block?

Copy link

@rhakeshj rhakeshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted few questions and comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants