Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add an example script for sending ussd codes #218

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mmubarak0
Copy link
Contributor

I do not know how, but sending a USSD code improves internet speed. It sometimes fixes the connection, which makes me send USSD codes frequently. other people may want to use it differently. maybe for knowing the data status more accurately than the one the UI shows. I have added some colors and waiting animation to make it visually appealing.
I'm not an experienced developer so any feedback would be helpful thanks.

Copy link
Owner

@Salamek Salamek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, code could be bit better and simpler (single thread), but it is ~ok as an example i guess so please just fix that one bug and i'll merge ;-)

examples/send_ussd.py Show resolved Hide resolved
@Salamek
Copy link
Owner

Salamek commented Jul 7, 2024

Ok, also there are some lint issues:

examples/send_ussd.py:38: error: Function is missing a return type annotation  [no-untyped-def]
  examples/send_ussd.py:38: note: Use "-> None" if function does not return a value
  examples/send_ussd.py:60: error: Non-overlapping equality check (left operand type: "Dict[str, Any]", right operand type: "Literal['OK']")  [comparison-overlap]
  Found 2 errors in 1 file (checked 108 source files)

@mmubarak0
Copy link
Contributor Author

I did fix these errors now but I think I have done it the wrong way by running mypy . manually.
what is the recommended way for running the lints checks?

@Salamek
Copy link
Owner

Salamek commented Jul 8, 2024

Running mypy . locally should do the trick, try to push those changes here and see how it goes ;-)

@Salamek Salamek merged commit d513878 into Salamek:master Jul 8, 2024
6 checks passed
@Salamek Salamek mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants