Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(message): add width prop #7196

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(message): add width prop #7196

wants to merge 1 commit into from

Conversation

nuria1110
Copy link
Contributor

fix #6966

Proposed behaviour

Add width prop to Message component.

Current behaviour

Message component does not have a width prop.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nuria1110
feat(message): add width prop
973d0b2 
Adds `width` prop to `Message` component, accepts any valid css string

fix #6966
@nuria1110 nuria1110 self-assigned this Feb 7, 2025
tomdavies73
tomdavies73 reviewed Feb 7, 2025
View reviewed changes
src/components/message/message.component.tsx
closeButtonAriaLabel?: string;
/** set custom id to component root */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick i'd separate any non-related changes into a chore commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdavies73 tomdavies73 tomdavies73 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nuria1110 nuria1110

Labels
No UX QA Required Pending QA Pending Review Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message Component: inline and width properties
2 participants
@nuria1110 @tomdavies73