Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude validations stories from Storybook #7189

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DobroTora
Copy link
Contributor

@DobroTora DobroTora commented Jan 31, 2025

Proposed behaviour

Screenshot 2025-01-31 at 13 52 12 Excluding Validations Story from Storybook

Current behaviour

Validations story do not display styles like other stories that display styles for validation state correctly.
GroupedCharacter_Validations_story_frame_no_validations

ISSUE: FE-7050

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@DobroTora DobroTora requested a review from a team as a code owner January 31, 2025 14:19
@DobroTora DobroTora self-assigned this Jan 31, 2025
@DobroTora DobroTora marked this pull request as draft January 31, 2025 14:20
@Parsium Parsium self-requested a review January 31, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant