docs(accordion): update documentation examples to ensure a11y compliance #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipperTheDan
previously approved these changes
Jan 22, 2025
mihai-albu-sage
previously approved these changes
Jan 23, 2025
damienrobson-sage
dismissed stale reviews from mihai-albu-sage and DipperTheDan
via
74b1a0a
damienrobson-sage
force-pushed
the
FE-7056
branch
from
74b1a0a to
eedcfe4
Compare
DipperTheDan
previously approved these changes
Jan 23, 2025
mihai-albu-sage
previously approved these changes
Jan 23, 2025
damienrobson-sage
dismissed stale reviews from mihai-albu-sage and DipperTheDan
via
e779c31
damienrobson-sage
force-pushed
the
FE-7056
branch
from
eedcfe4 to
e779c31
Compare
DipperTheDan
approved these changes
Jan 24, 2025
mihai-albu-sage
approved these changes
Jan 27, 2025
sianford
approved these changes
Jan 28, 2025
|
🎉 This PR is included in version 147.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Update the documented examples to be a11y-compliant
Current behaviour
Documented examples of Accordion which render mutliple instances with content throw an a11y violation indicating non-unique landmarks
Checklist
d.tsfile added or updated if requiredQA
Testing instructions
Run AXE DevTools against any of the Accordion Storybook examples with more than one collapsed accordion on it. Regardless of open/closed state, no error should be flagged