Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hr): add height prop #7159

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(hr): add height prop #7159

wants to merge 1 commit into from
+100 −2

Conversation

robkilby
Copy link
Member

@robkilby robkilby commented Jan 17, 2025 •
edited by tomdavies73
Loading

Proposed behaviour

Screenshot 2025-01-28 at 13 43 10

Current behaviour

image

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

@robkilby robkilby self-assigned this Jan 17, 2025
@robkilby robkilby requested review from a team as code owners January 17, 2025 14:03
@harpalsingh
Copy link
Member

Speaking with DS @ljemmo and something I think also makes most sense is to limit this to 3 sizes, to avoid it be incorrectly used. So we were thinking for the height prop to target "small == 1px" "medium == 2px" "large == 3px" thanks

@tomdavies73 tomdavies73 self-requested a review January 20, 2025 11:21
@edleeks87 edleeks87 marked this pull request as draft January 20, 2025 11:39
@tomdavies73 tomdavies73 force-pushed the separator-custom-height branch 2 times, most recently from 6165677 to 65229f2 Compare January 28, 2025 13:40
@robkilby @tomdavies73
feat(hr): add height prop
b93ab1c 
adds the height prop to the hr component, consumers can now customise the
height with three available sizes: small, medium and large (1px, 2px, 3px)
@tomdavies73 tomdavies73 force-pushed the separator-custom-height branch from 65229f2 to b93ab1c Compare January 28, 2025 13:41
@tomdavies73 tomdavies73 changed the title feat: allow the height of the hr component to be specified feat(hr): add height prop Jan 28, 2025
@tomdavies73 tomdavies73 removed their request for review January 28, 2025 13:42
@tomdavies73 tomdavies73 self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DipperTheDan DipperTheDan DipperTheDan approved these changes

@damienrobson-sage damienrobson-sage damienrobson-sage approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@robkilby robkilby

@tomdavies73 tomdavies73

Labels
Pending QA Pending Review Pending UX QA Squad Front End Squad Vortex third-party
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robkilby @harpalsingh @damienrobson-sage @DipperTheDan @tomdavies73