SWC-7067 #5611
SWC-7067 #5611
Conversation
| public class CardConfiguration { | ||
|
|
||
| String type; | ||
| double secondaryLabelLimit; |
There was a problem hiding this comment.
| double secondaryLabelLimit; | |
| long secondaryLabelLimit; |
There was a problem hiding this comment.
Did something change, I thought long values were disallowed? Or perhaps I'm misunderstanding.
From https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html
The Java long type cannot be represented in JavaScript as a numeric type, so GWT emulates it using an opaque data structure. This means that JSNI methods cannot process a long as a numeric type. The compiler therefore disallows, by default, directly accessing a long from JSNI: JSNI methods cannot have long as a parameter type or a return type, and they cannot access a long using a JSNI reference.
There was a problem hiding this comment.
This is JsInterop, not JSNI. However, it seems like double is the least problematic primitive type for JsInterop. In JsInterop, int and long do work; we're using those for properties in other JsInterop types. I cannot find an authoritative document that describes exactly what Java primitives and classes JsInterop supports.
Keeping double is probably fine!
There was a problem hiding this comment.
Right! I'm still thinking in JSNI. I guess I'll leave it, for the small potential performance gain
No description provided.