[GEN-1615] Add new cohorts #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Nice, one day we will be able to deprecate dockerhub completely...
thomasyu888
approved these changes
Jan 30, 2025
|
|
This is no longer blocked by GEN-1717 |
danlu1
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
LGTM. QQ: do we have a SOP for adding new cohorts? I didn't find it here: https://sagebionetworks.jira.com/wiki/spaces/APGD/pages/2178941044/GENIE+Sponsored+Project+SOP or https://sagebionetworks.jira.com/wiki/spaces/APGD/pages/2621931648/GENIE+BPC+Pipeline+SOP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: Here are all the known changes we need to make to the SP release process to add new cohorts. Things like
_exclude_filesare set to be empty for the new cohorts because we don't have that information yet.Testing: