Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop rspec #117

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Update rubocop rspec #117

merged 1 commit into from
Jul 11, 2024

Conversation

baldarn
Copy link
Contributor

@baldarn baldarn commented Jul 10, 2024

rubocop rspec had a major update (version 3) and is splitting code for rails, capybara and factorybot

this pr moves on to version 3

there are lots of new rules.

I would suggest to update this and move update in our project. if needed, we can schedule the update with rubocop todo in each project

Copy link
Contributor

@Sergeykot Sergeykot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@josegomezr josegomezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we'll see the new rules on the next depfu round for the codestyle gem :P

@baldarn baldarn merged commit e5a275d into master Jul 11, 2024
5 checks passed
@baldarn baldarn deleted the update-rubocop-rspec branch July 11, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants